[Inline Code]: Update children prop #4109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
🦋 Changeset detectedLatest commit: 155fd38 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dosubot
bot
added
the
size:S
github-actions
bot
added
the
Status: Do Not Merge
github-actions
bot
added
the
Area: Components
PixeledCode
force-pushed
the
truncate-inline
branch
from
038ef92 to
e0f8efc
Compare
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 155fd38. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
|
Size Change: 0 B Total Size: 1.1 MB ℹ️ View Unchanged
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 155fd38:
|
Paste
|
||||||||||||||||||||||||
| Project |
Paste
|
| Run status |
|
| Run duration | 02m 06s |
| Commit |
|
| Committer | kodiakhq[bot] |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
67
|
nkrantz
reviewed
Oct 16, 2024
.changeset/spicy-badgers-double.md
Outdated
Comment on lines
2
to
3
| "@twilio-paste/inline-code": minor | ||
| "@twilio-paste/core": minor |
There was a problem hiding this comment.
suggestion: this can be a patch since we're not adding any new props or exports
nkrantz
reviewed
Oct 16, 2024
| @@ -94,6 +95,16 @@ export const DisplayingAPIKey: StoryFn = () => { | |||
| ); | |||
| }; | |||
|
|
|||
| export const WithTruncate: StoryFn = () => { | |||
There was a problem hiding this comment.
suggestion: could you also add a story with a truncated inline code within a block of regular paragraph text?
PixeledCode
force-pushed
the
truncate-inline
branch
from
e0f8efc to
0a76d9c
Compare
krisantrobus
approved these changes
Oct 16, 2024
PixeledCode
added
🚀 merge it!
🕵🏻♀️ Run website visual regression
serifluous
approved these changes
Oct 16, 2024
Paste
|
||||||||||||||||||||||||
| Project |
Paste
|
| Run status |
|
| Run duration | 06m 01s |
| Commit |
|
| Committer | Shoaib Ahmed |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
Failures
|
0
|
|
Flaky
|
0
|
|
Pending
|
0
|
|
Skipped
|
0
|
|
Passing
|
125
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.